Skip to content

fix(vmip): fix display of conditions Bound and Attached#948

Merged
LopatinDmitr merged 1 commit into
mainfrom
fix/vmip/fix-display-conditions
Apr 23, 2025
Merged

fix(vmip): fix display of conditions Bound and Attached#948
LopatinDmitr merged 1 commit into
mainfrom
fix/vmip/fix-display-conditions

Conversation

@LopatinDmitr
Copy link
Copy Markdown
Contributor

@LopatinDmitr LopatinDmitr commented Apr 20, 2025

Description

This PR refactors the lifecycle handler logic for VirtualMachineIPAddress (VMIP) resources to simplify the state management.

Key behavior changes:

  • The VMIP phase will now always be updated in each case, rather than only when it differs from the current phase.
  • The attachment to a VirtualMachine is now handled as part of the Bound case rather than as a separate condition.

Why do we need it, and what problem does it solve?

The VirtualMachineIPAddress resource have Bound and Attached conditions with status Unknown.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmip 
type: fix
summary: Improve Status Reporting
impact_level: low

@LopatinDmitr LopatinDmitr added this to the v0.17.0 milestone Apr 20, 2025
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-display-conditions branch from 47a3755 to 67d2ce0 Compare April 21, 2025 07:42
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-display-conditions branch from 67d2ce0 to 15c795b Compare April 22, 2025 11:34
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@LopatinDmitr LopatinDmitr marked this pull request as ready for review April 22, 2025 13:20
@LopatinDmitr LopatinDmitr requested a review from Isteb4k as a code owner April 22, 2025 13:20
@LopatinDmitr LopatinDmitr merged commit bade31d into main Apr 23, 2025
86 of 99 checks passed
@LopatinDmitr LopatinDmitr deleted the fix/vmip/fix-display-conditions branch April 23, 2025 07:56
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants